refactor: Separate trait parsing & structuring from QObject #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 72 +1
Lines 13048 13009 -39
=========================================
- Hits 13048 13009 -39 ☔ View full report in Codecov by Sentry. |
BenFordTytherington
force-pushed
the
938-separate-trait-parsing
branch
3 times, most recently
from
06ef365 to
cc2919d
Compare
LeonMatthesKDAB
force-pushed
the
938-separate-trait-parsing
branch
from
cc2919d to
ca8c2ce
Compare
Move the association between QObject and trait into the structuring phase. This should be one of the last things left in the structuring refactor. Fix KDAB#938
Now that we've moved everything into the structuring phase, this is no longer necessary and simplifies parsing a lot. Todo: Make the list of QObjects a Vec, instead of a BTreeMap.
…quick lookup function
LeonMatthesKDAB
force-pushed
the
938-separate-trait-parsing
branch
from
16fc55a to
ad33e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.