Refactor ParsedMethod, ParsedSignal and ParsedInheritedMethod #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BenFordTytherington
commented
Aug 29, 2024
BenFordTytherington
commented
- Refactor method and inherited method to have docs passthrough
- Group common functionality between these 3 similar structs
…ike ParsedSignal - ParsedSignal had a `docs: Vec<Attribute>` field, and it seemed appropriate to add this to method and inherited methods too Is this the intended use?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1054 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 13009 13061 +52
=========================================
+ Hits 13009 13061 +52 ☔ View full report in Codecov by Sentry. |
…sedInheritedMethod Includes introducing a struct and associated functions for the common fields, combining the common logic for parsing those fields. Also adds methods to build those types from the InvokableFields struct
|
Is it useful to combine all these invokable types in |
….g. Function searches for non-inherited methods first
…to be refactored - They now implement an Invokable trait which can be extended to improve shared functionality - This allowed refactoring of method and signal lookup to use a common lookup function
BenFordTytherington
force-pushed
the
refactor-invokable
branch
from
b9fb0db to
f499b9a
Compare
LeonMatthesKDAB
requested changes
Sep 1, 2024
- Moved MethodFields and its renamed method to method.rs - Updated the expected outputs - Refactor the lookup method to be generic, and remove the superfluous trait
LeonMatthesKDAB
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.