Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: cxx-qt-build: use isolated cc::Build for QmlModules #1066

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

WIP: cxx-qt-build: use isolated cc::Build for QmlModules #1066

wants to merge 16 commits into from

Conversation

ahayzen-kdab
Copy link
Collaborator

Closes #1065

@ahayzen-kdab
cxx-qt-build: consider the folders in rust path
42f9cbf 
Closes KDAB#855
@ahayzen-kdab
cxx-qt-gen: require cxx_file_stem until Span::source_file is stable
826c7f4 
Closes KDAB#855
@ahayzen-kdab
cxx-qt-gen: change writer phase to take include path from cxx-qt-build
3eee54c
@ahayzen-kdab
cxx-qt-build: place moc and other files into folder and include moc
f5c9c1a
@ahayzen-kdab
cxx-qt-build: injected include needs the prefix of the crate
09be6e5
@ahayzen-kdab
cxx-qt-gen: purge cxx_file_stem
2fe77b0
@ahayzen-kdab
cxx-qt-gen: fix failing tests
52cf165
@ahayzen-kdab
book: remove line about cxx_file_stem and Span::source_file()
8492f21
@ahayzen-kdab
cxx-qt-gen: add test to ensure cxx_file_stem fails
57a2a9b
@ahayzen-kdab
errors: improve error messages for cxx_file_stem and multiple dirs
0e36c7a
@ahayzen-kdab
cxx-qt-build: remove use of syn it is not used
1255807
@ahayzen-kdab
cxx-qt-build: use a cloned builder for qml modules
d06390e
@ahayzen-kdab
cxx-qt-build: use full directory path when comparing qml roots
62757b5
@ahayzen-kdab
cxx-qt-build: use only link when building
d0e2a20
@ahayzen-kdab
cxx-qt-build: use same builder for now for all qml modules
7c6034e
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (da72ec5) to head (92b97bc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1066   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        70    -1     
  Lines        12042     11991   -51     
=========================================
- Hits         12042     11991   -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahayzen-kdab ahayzen-kdab mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QmlModule in cxx-qt-build should use their own isolated cc::Build
1 participant
@ahayzen-kdab