fix build failure with empty qml bridges (closes #1033) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good thanks! Just some minor things to make CI happy |
aambrosano
force-pushed
the
fix_empty_qml_bridges_build_fail
branch
from
74a2c90 to
3f982c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1073 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 70 70
Lines 12011 12011
=========================================
Hits 12011 12011 ☔ View full report in Codecov by Sentry. |
aambrosano
force-pushed
the
fix_empty_qml_bridges_build_fail
branch
from
3f982c6 to
65b048e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1033