Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt: remove handle_property_change instead rely on QML/C++ #151

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

For now remove the handle_property_change this reduces complexity
as a connection can be made on the QML/C++ side to an invokable.

Later once properties live on the Rust side it might be possible
to create connections on the Rust side of the bridge.

Change-Id: I76db85f5f094964c1b0e543d8284b384b4767aa9

@ahayzen-kdab ahayzen-kdab force-pushed the remove-handle-property-change branch 2 times, most recently from 911c057 to f197b4a Compare July 15, 2022 11:21
For now remove the handle_property_change this reduces complexity
as a connection can be made on the QML/C++ side to an invokable.

Later once properties live on the Rust side it might be possible
to create connections on the Rust side of the bridge.

Change-Id: I76db85f5f094964c1b0e543d8284b384b4767aa9
@ahayzen-kdab ahayzen-kdab force-pushed the remove-handle-property-change branch from f197b4a to 06bffd3 Compare July 19, 2022 17:24
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for CI

@Be-ing Be-ing merged commit dc715e5 into KDAB:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants