Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CLI tool for C++ code generation #161

Merged
merged 4 commits into from
Jul 19, 2022
Merged

add CLI tool for C++ code generation #161

merged 4 commits into from
Jul 19, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 15, 2022

implementing #146

@Be-ing Be-ing force-pushed the cli_tool branch 4 times, most recently from 3730b9c to 75f6203 Compare July 16, 2022 02:05
ahayzen-kdab
ahayzen-kdab requested changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, a few comments :-)

cxx-qt-cli/Cargo.toml Outdated Show resolved Hide resolved
cxx-qt-cli/Cargo.toml Show resolved Hide resolved
cxx-qt-cli/Cargo.toml Show resolved Hide resolved
cxx-qt-cli/src/main.rs Outdated Show resolved Hide resolved
cxx-qt-cli/src/main.rs Outdated Show resolved Hide resolved
cxx-qt-build/src/lib.rs Show resolved Hide resolved
cxx-qt-cli/src/main.rs Show resolved Hide resolved
cxx-qt-build/src/lib.rs Show resolved Hide resolved
cxx-qt-build/src/lib.rs Outdated Show resolved Hide resolved
cxx-qt-gen/src/gen_cpp.rs Outdated Show resolved Hide resolved
@Be-ing
cxx-qt-build: decouple code generation from file writing
9d577aa 
also cleanup ambiguous usage of str/String with Path/PathBuf

The locations of generated files have been changed for consistency
and simplifying the code. Previously, C++ code generated by cxx was
put in files named based on the Rust file name and the C++ header
file was confusingly put in the src directory. This has been changed
so all files use the snake_cased version of the cxx module name,
with the files generated by cxx having a _cxx suffix. Both cxx's
and cxx-qt's generated headers are now in the include directory.
@Be-ing Be-ing force-pushed the cli_tool branch 2 times, most recently from 697cad1 to e6baa1b Compare July 19, 2022 06:04
ahayzen-kdab
ahayzen-kdab reviewed Jul 19, 2022
View reviewed changes
cxx-qt-cli/Cargo.toml Outdated Show resolved Hide resolved
@Be-ing Be-ing force-pushed the cli_tool branch 2 times, most recently from ca49b75 to 0cd975e Compare July 19, 2022 15:56
ahayzen-kdab
ahayzen-kdab approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab merged commit 8931138 into KDAB:main Jul 19, 2022
@Be-ing Be-ing deleted the cli_tool branch July 19, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ahayzen-kdab