cxx-qt-lib: use unique ptr types and don't wrap #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
154-use-unique-ptr-types
branch
2 times, most recently
from
151159c to
33e1502
Compare
This was referenced Jul 21, 2022
|
The Rust is failing to link on Windows. |
Be-ing
reviewed
Jul 21, 2022
Yup, we are unsure why or what's changed specifically to break that so far... |
Be-ing
reviewed
Jul 21, 2022
ahayzen-kdab
force-pushed
the
154-use-unique-ptr-types
branch
from
33e1502 to
b7eadc0
Compare
|
Please leave a comment when you get the Windows build working again. |
Be-ing
reviewed
Jul 22, 2022
ahayzen-kdab
force-pushed
the
154-use-unique-ptr-types
branch
4 times, most recently
from
d9c9073 to
2144858
Compare
ahayzen-kdab
force-pushed
the
154-use-unique-ptr-types
branch
4 times, most recently
from
f355bc6 to
5c063f1
Compare
Be-ing
reviewed
Aug 2, 2022
Be-ing
reviewed
Aug 2, 2022
Be-ing
reviewed
Aug 2, 2022
This will greatly simplify the generation later as we'll be able to remove the pattern matching. Also it requires the developer to perform what can be costly conversions, so this then is more Rust-like as it points to where close might be.
For now remove Rust's strings as supported types as these need to go through the UTF conversion. Instead require the developer to invoke the conversion themselves. Once pattern matching is removed we can support CxxString etc.
ahayzen-kdab
force-pushed
the
154-use-unique-ptr-types
branch
from
5c063f1 to
75a33f3
Compare
Be-ing
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will greatly simplify the generation later as we'll be
able to remove the pattern matching. Also it requires the
developer to perform what can be costly conversions, so
this then is more Rust-like as it points to where close might be.