Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cxx-qt-gen: add cxx_qt::qobject to determine which struct is the QObject #197

Merged
merged 1 commit into from
Aug 10, 2022
Merged

cxx-qt-gen: add cxx_qt::qobject to determine which struct is the QObject #197

merged 1 commit into from
Aug 10, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #195 #196

@ahayzen-kdab ahayzen-kdab mentioned this pull request Aug 9, 2022
Closed
53 tasks
ahayzen-kdab
ahayzen-kdab commented Aug 9, 2022
View reviewed changes
README.md Show resolved Hide resolved
@ahayzen-kdab ahayzen-kdab mentioned this pull request Aug 9, 2022
Merged
@ahayzen-kdab ahayzen-kdab force-pushed the add-cxx-qt-qobject-macro branch 3 times, most recently from a95a808 to cc5f7b1 Compare August 9, 2022 17:07
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review August 9, 2022 17:08
@LeonMatthesKDAB LeonMatthesKDAB enabled auto-merge (squash) August 10, 2022 13:48
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the add-cxx-qt-qobject-macro branch from cc5f7b1 to 1bae218 Compare August 10, 2022 13:48
LeonMatthesKDAB
LeonMatthesKDAB requested changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd want to see at least one full test from input->output that uses another name than RustObj.

Otherwise looks good 👍

cxx-qt-gen/src/extract.rs Outdated Show resolved Hide resolved
cxx-qt-gen/test_inputs/invokables.rs Show resolved Hide resolved
@ahayzen-kdab ahayzen-kdab force-pushed the add-cxx-qt-qobject-macro branch from 1bae218 to 53f0fd1 Compare August 10, 2022 14:07
LeonMatthesKDAB
LeonMatthesKDAB approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonMatthesKDAB LeonMatthesKDAB merged commit b62375a into KDAB:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonMatthesKDAB LeonMatthesKDAB LeonMatthesKDAB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @LeonMatthesKDAB