Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CppObj #202

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove CppObj #202

merged 1 commit into from
Aug 25, 2022

Conversation

LeonMatthesKDAB
Copy link
Collaborator

This will move all invokables onto MyObjectQt and remove the need for
the CppObj.

@LeonMatthesKDAB LeonMatthesKDAB force-pushed the remove-cppobj branch 5 times, most recently from 121c8a3 to ff6d039 Compare August 12, 2022 13:40
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the remove-cppobj branch 5 times, most recently from d878088 to 50de2c2 Compare August 19, 2022 14:20
This will move all invokables onto MyObjectQt and remove the need for
the CppObj.
@LeonMatthesKDAB LeonMatthesKDAB marked this pull request as ready for review August 19, 2022 14:22
@Be-ing
Copy link
Contributor

Be-ing commented Aug 22, 2022

Is this still a WIP? If not, please change the title of the PR.

@ahayzen-kdab ahayzen-kdab changed the title [WIP] Remove CppObj Remove CppObj Aug 25, 2022
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets land this as a first step so we can move forward and parallelise tasks

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) August 25, 2022 02:21
@ahayzen-kdab ahayzen-kdab merged commit efe21fe into KDAB:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants