cxx-qt-gen: use impl qobject::T to define the C++ context #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
use-qobject-mod-for-cpp-context
branch
2 times, most recently
from
ec9d39a to
add45c0
Compare
This was referenced Oct 3, 2022
Be-ing
previously approved these changes
Oct 6, 2022
There was a problem hiding this comment.
I liked the impl cxx_qt::QObject<T> but I understand the issues with it. impl qobject::T feels backwards; I would prefer impl T::qobject. Maybe there would be a way to do that with associated types, but I also understand the issues that would bring up as discussed in #237.
Be-ing
force-pushed
the
use-qobject-mod-for-cpp-context
branch
from
add45c0 to
9576f44
Compare
Be-ing
force-pushed
the
use-qobject-mod-for-cpp-context
branch
from
9576f44 to
e29a724
Compare
Be-ing
previously approved these changes
Oct 6, 2022
|
As a follow-up, it would be good to have a test using a QObject type from one cxx-qt module in another cxx-qt module. |
This is something to figure out in 0.5 #299 as we might need more API we'll see (eg types to define ownership). But in theory the API is now close. |
This then creates a natural way to add methods to the C++ context. It also means later with nested objects they can be referred to by crates::module::qobject::MyObject. And any Rust traits or methods are natural as they are impl A for T, with traits for the C++ object being natural with impl A for qobject::T
ahayzen-kdab
force-pushed
the
use-qobject-mod-for-cpp-context
branch
from
e29a724 to
dc63f07
Compare
Be-ing
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This then creates a natural way to add methods to the C++ context.
It also means later with nested objects they can be referred to by crates::module::qobject::MyObject.
And any Rust traits or methods are natural as they are impl A for T, with traits for the C++ object being natural with impl A for qobject::T