qt-build-utils: vendor code from pkg-config #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
decouple_pkg-config
branch
from
293606e to
b53bfba
Compare
instead of using my branch hacking some private pkg-config functions to be public. Publication to crates.io requires only using crates on crates.io, not Git URLs.
Be-ing
force-pushed
the
decouple_pkg-config
branch
from
b53bfba to
7130c23
Compare
|
There's likely some code in here that isn't strictly necessary, but I tried to keep it close to the upstream code in pkg-config to make maintenance easier. |
ahayzen-kdab
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using my branch hacking some private pkg-config functions to be public. Publication to crates.io requires only using crates on crates.io, not Git URLs.
This also removes the dependency on regex which is overkill for the string processing required.
Fixes #304