-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-gen: generate docs for public generated items #518
cxx-qt-gen: generate docs for public generated items #518
Conversation
2e4ee9b
to
71f6b35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that cargo doc
on qml_features actually doesn't pick up most of the generated documentation, or even functions at all!
To track this I've crated #529
Ideally we should address this issue with this PR as well.
As otherwise it doesn't make much sense to be able to do #[deny(missing_docs)]
if the docs then don't show up in the output at all...
a0dc346
to
7b0ebaa
Compare
7b0ebaa
to
2fc5664
Compare
2fc5664
to
64a9e56
Compare
So generated docs now are sane, not perfect, but better. |
If your bridge module isn't |
64a9e56
to
0195de5
Compare
This ensures we don't regress with any missing docs for generated public items, related to KDAB#517
0195de5
to
1e6a998
Compare
Sigh macOS and Windows fail to run |
1e6a998
to
1c99d10
Compare
Magic moving the CI now passes :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of nitpicks
3cb1d8d
to
42ec8f3
Compare
Closes #517