Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx_qt::Constructor: Add tests #608

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

LeonMatthesKDAB
Copy link
Collaborator

Follow up on #566

@Be-ing Be-ing force-pushed the constructor-trait-tests branch from 5dc412f to e4e0564 Compare July 17, 2023 16:44
@Be-ing
Copy link
Contributor

Be-ing commented Jul 17, 2023

CI passes since rebasing after merging #609

@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-trait-tests branch 2 times, most recently from 47a39b5 to 82e4225 Compare July 21, 2023 07:51
@LeonMatthesKDAB LeonMatthesKDAB marked this pull request as ready for review July 21, 2023 07:59
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-trait-tests branch from 82e4225 to 1d7a1b5 Compare July 21, 2023 09:17
crates/.gitignore Outdated Show resolved Hide resolved
@LeonMatthesKDAB LeonMatthesKDAB force-pushed the constructor-trait-tests branch from 1d7a1b5 to 038bb98 Compare July 21, 2023 09:55
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) July 21, 2023 10:23
@ahayzen-kdab ahayzen-kdab merged commit 26332e1 into KDAB:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants