Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: ensure mod and fn are pub so that doc page works #632

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

ahayzen-kdab
Copy link
Collaborator

This then shows how a doc page is generated correctly for our QObjects.

Closes #529

@ahayzen-kdab ahayzen-kdab force-pushed the 529-ensure-pub-methods-ffi branch 3 times, most recently from 18068bd to 0d8172c Compare July 28, 2023 09:09
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few nitpicks

examples/qml_features/rust/src/custom_parent_class.rs Outdated Show resolved Hide resolved
examples/qml_features/rust/src/invokables.rs Show resolved Hide resolved
examples/qml_features/rust/src/nested_qobjects.rs Outdated Show resolved Hide resolved
This then shows how a doc page is generated correctly for
our QObjects.

Closes KDAB#529
@ahayzen-kdab ahayzen-kdab force-pushed the 529-ensure-pub-methods-ffi branch from 0d8172c to 8c1283b Compare July 28, 2023 09:42
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahayzen-kdab ahayzen-kdab merged commit 0af59b9 into KDAB:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated documentation doesn't show up on qobject::T
2 participants