Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit lib prefix for .prl files on all Windows targets #643

Merged
merged 1 commit into from
Aug 1, 2023
Merged

omit lib prefix for .prl files on all Windows targets #643

merged 1 commit into from
Aug 1, 2023

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jul 31, 2023

to fix build with MinGW
#640

@Be-ing Be-ing mentioned this pull request Jul 31, 2023
Closed
@Be-ing Be-ing marked this pull request as draft July 31, 2023 14:28
@Be-ing
Copy link
Contributor Author

Be-ing commented Jul 31, 2023

Marking as a draft until this has been tested with MinGW

@Be-ing Be-ing marked this pull request as ready for review August 1, 2023 01:53
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 1, 2023

Confirmed working for MinGW, now ready for review.

ahayzen-kdab
ahayzen-kdab approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab merged commit 48bd4c2 into KDAB:main Aug 1, 2023
@Be-ing Be-ing deleted the mingw_prl branch August 1, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ahayzen-kdab