-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-gen: add Rust generator and writer of extern "C++Qt" #662
Merged
ahayzen-kdab
merged 3 commits into
KDAB:main
from
ahayzen-kdab:577-generate-rust-signals
Aug 25, 2023
Merged
cxx-qt-gen: add Rust generator and writer of extern "C++Qt" #662
ahayzen-kdab
merged 3 commits into
KDAB:main
from
ahayzen-kdab:577-generate-rust-signals
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
from
August 11, 2023 17:05
bb64c79
to
dc18add
Compare
ahayzen-kdab
commented
Aug 11, 2023
ahayzen-kdab
commented
Aug 11, 2023
ahayzen-kdab
commented
Aug 11, 2023
ahayzen-kdab
commented
Aug 11, 2023
ahayzen-kdab
commented
Aug 11, 2023
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
4 times, most recently
from
August 18, 2023 14:25
599de7f
to
816666a
Compare
ahayzen-kdab
changed the title
WIP: cxx-qt-gen: add Rust generator and writer of extern "C++Qt"
cxx-qt-gen: add Rust generator and writer of extern "C++Qt"
Aug 18, 2023
No example yet as we need to add support for closures in signal connection as well as function pointers to make them useful. This will likely be similar to how threading is done and #595 can be reused |
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
from
August 24, 2023 08:27
816666a
to
0515c02
Compare
ahayzen-kdab
added a commit
to ahayzen-kdab/cxx-qt
that referenced
this pull request
Aug 24, 2023
This allows us later to pass through the original method in the generation. Related to KDAB#662
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
from
August 24, 2023 09:29
0515c02
to
23e5c4b
Compare
ahayzen-kdab
added a commit
to ahayzen-kdab/cxx-qt
that referenced
this pull request
Aug 24, 2023
This allows us later to pass through the original method in the generation. Related to KDAB#662
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
from
August 24, 2023 09:33
23e5c4b
to
d5fe11d
Compare
ahayzen-kdab
added a commit
to ahayzen-kdab/cxx-qt
that referenced
this pull request
Aug 24, 2023
This allows us later to pass through the original method in the generation. Related to KDAB#662
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
from
August 24, 2023 10:17
d5fe11d
to
34fa65f
Compare
ahayzen-kdab
added a commit
to ahayzen-kdab/cxx-qt
that referenced
this pull request
Aug 24, 2023
This allows us later to pass through the original method in the generation. Related to KDAB#662
ahayzen-kdab
force-pushed
the
577-generate-rust-signals
branch
3 times, most recently
from
August 24, 2023 16:14
48e7b61
to
2b6a244
Compare
This allows us later to pass through the original method in the generation. Related to KDAB#662
Be-ing
force-pushed
the
577-generate-rust-signals
branch
from
August 24, 2023 20:43
2b6a244
to
cf5ad21
Compare
ahayzen-kdab
added a commit
to ahayzen-kdab/cxx-qt
that referenced
this pull request
Aug 25, 2023
This allows us later to pass through the original method in the generation. Related to KDAB#662
LeonMatthesKDAB
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ahayzen-kdab
added a commit
that referenced
this pull request
Aug 25, 2023
This allows us later to pass through the original method in the generation. Related to #662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #577