WIP: cargo: ensure cc crate is less than 1.0.84 #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Nov 13, 2023
ahayzen-kdab
force-pushed
the
fix-macos-cpp-lib
branch
from
e8a255e to
238df48
Compare
ahayzen-kdab
commented
Nov 13, 2023
ahayzen-kdab
force-pushed
the
fix-macos-cpp-lib
branch
from
238df48 to
39e6b50
Compare
ahayzen-kdab
changed the title
ahayzen-kdab
force-pushed
the
fix-macos-cpp-lib
branch
from
6d797e6 to
8319863
Compare
Otherwise we have: error: 'shared_mutex' is unavailable: introduced in macOS 10.12 error: 'path' is unavailable: introduced in macOS 10.15
ahayzen-kdab
commented
Nov 15, 2023
| # With macOS we need | ||
| # - std::filesystem::path from 10.15 | ||
| # - std::shared_mutex from 10.12 | ||
| MACOSX_DEPLOYMENT_TARGET: 10.15 |
There was a problem hiding this comment.
wonder if we just always set this in CI
As the minimum version for rustc will be 10.12 but we need 10.15
https://blog.rust-lang.org/2023/09/25/Increasing-Apple-Version-Requirements.html
There was a problem hiding this comment.
Setting this on CI is fine, but it doesn't solve the problem of new versions of cc breaking the build when downstream users haven't set the environment variable. Fixed in #825
|
CI is now working again so this is not required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.