qtypes: add support for Qt alias types that don't match #904

ahayzen-kdab · 2024-03-28T17:17:58Z

Closes #882

crates/cxx-qt-lib/src/core/qtypes.rs

crates/cxx-qt-lib/src/core/qtypes.cpp

crates/cxx-qt-lib-headers/include/core/qtypes.h

codecov · 2024-09-05T16:04:25Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e6ee353) to head (709d25d).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #904   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines        11949     11949           
=========================================
  Hits         11949     11949

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/cxx-qt-lib/src/core/mod.rs

crates/cxx-qt-lib/src/core/qtypes.rs

LeonMatthesKDAB

Overall this looks good.
Naming wise I would just copy Qts casing (so lowercase). These types are quiet "fundamental types", which even in Rust are lowercase (i64, isize, etc.).

A sort-off open question is still how many operations we want to support on these...
Do we basically just enable From/Into and call it a day, or do we want to have support for using the type more directly, like support for +-*/ on qint64...

For now it's probably good enough if we just have them convertable to their inner type, but something to keep in mind.

On the same note: Maybe we don't want to support Deref on these types?
It may be weird if you call e.g. abs on qint64, but get an i64 back...
And now it would be a breaking change for us to add our own abs method that returns qint64...

So it seems like limiting the API to just From/To with some derives is maybe best?

LeonMatthesKDAB · 2024-10-21T09:30:08Z

crates/cxx-qt-lib/src/core/qtypes.rs

+
+/// Typedef for long long int. This type is guaranteed to be 64-bit on all platforms supported by Qt.
+#[repr(transparent)]
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]


I would add Clone and Copy to this list as well...

LeonMatthesKDAB · 2024-10-21T09:31:09Z

crates/cxx-qt-lib/src/core/qtypes.rs

+/// Typedef for long long int. This type is guaranteed to be 64-bit on all platforms supported by Qt.
+#[repr(transparent)]
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
+pub struct QInt64(i64);


Let's go with qint64 here. No need to rename the type. It's still a sort off "fundamental type" like i64, which is also lowercase.

LeonMatthesKDAB · 2024-10-21T09:31:38Z

crates/cxx-qt-lib/src/core/qtypes.rs

+
+/// Integral type for representing pointers in a signed integer (useful for hashing, etc.).
+#[repr(transparent)]
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]


Again, let's add Copy and Clone to that list :)

LeonMatthesKDAB · 2024-10-21T09:31:53Z

crates/cxx-qt-lib/src/core/qtypes.rs

+///
+/// Note that configuring Qt with -qreal float is not supported
+#[repr(transparent)]
+#[derive(Default, Debug, PartialEq, PartialOrd)]


Copy + Clone

LeonMatthesKDAB · 2024-10-21T09:32:15Z

crates/cxx-qt-lib/src/core/qtypes.rs

+
+/// Typedef for unsigned long long int. This type is guaranteed to be 64-bit on all platforms supported by Qt.
+#[repr(transparent)]
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]


Copy + Clone

LeonMatthesKDAB · 2024-10-21T09:32:26Z

crates/cxx-qt-lib/src/core/qtypes.rs

+
+/// Integral type for representing pointers in an unsigned integer (useful for hashing, etc.).
+#[repr(transparent)]
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]


Copy + Clone

LeonMatthesKDAB · 2024-10-21T09:32:34Z

crates/cxx-qt-lib/src/core/qtypes.rs

+/// Integral type providing Posix' ssize_t for all platforms.
+///
+/// This type is guaranteed to be the same size as a size_t on all platforms supported by Qt.
+#[derive(Default, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]


Copy + Clone

Some times don't match the Rust types so add these missing types. Closes KDAB#882

ahayzen-kdab · 2024-11-05T17:53:01Z

CHANGELOG.md

@@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

 ## [Unreleased](https://github.com/KDAB/cxx-qt/compare/v0.7.0...HEAD)

+### Added
+
+- Support for further types: `qreal`, `qint64`, `qintptr`, `qsizetype`, `quint64`, `quintptr`


do we also want qlonglong, qulonglong, or qptrdiff ?

See https://doc.qt.io/qt-6/qttypes.html#types for full types in Qt

ahayzen-kdab commented Mar 28, 2024

View reviewed changes

crates/cxx-qt-lib/src/core/qtypes.rs Outdated Show resolved Hide resolved

ahayzen-kdab force-pushed the 882-add-qtypes branch from e8826f5 to e409d32 Compare March 28, 2024 17:28

Montel reviewed Mar 29, 2024

View reviewed changes

crates/cxx-qt-lib/src/core/qtypes.rs Outdated Show resolved Hide resolved

crates/cxx-qt-lib/src/core/qtypes.cpp Outdated Show resolved Hide resolved

crates/cxx-qt-lib-headers/include/core/qtypes.h Outdated Show resolved Hide resolved

ahayzen-kdab mentioned this pull request Apr 16, 2024

WIP: experiment of using cfg options for differing Qt types #926

Closed

ahayzen-kdab force-pushed the 882-add-qtypes branch from e409d32 to e5daff8 Compare September 5, 2024 16:00

ahayzen-kdab force-pushed the 882-add-qtypes branch 2 times, most recently from debf9b7 to 79cc8fe Compare October 11, 2024 10:49

ahayzen-kdab commented Oct 11, 2024

View reviewed changes

crates/cxx-qt-lib/src/core/mod.rs Outdated Show resolved Hide resolved

ahayzen-kdab commented Oct 11, 2024

View reviewed changes

crates/cxx-qt-lib/src/core/qtypes.rs Outdated Show resolved Hide resolved

ahayzen-kdab force-pushed the 882-add-qtypes branch 3 times, most recently from 6a21207 to c67af09 Compare October 11, 2024 14:27

ahayzen-kdab marked this pull request as ready for review October 11, 2024 14:29

ahayzen-kdab changed the title ~~WIP: qtypes: add support for Qt alias types that don't match~~ qtypes: add support for Qt alias types that don't match Oct 11, 2024

ahayzen-kdab force-pushed the 882-add-qtypes branch from c67af09 to 709d25d Compare October 11, 2024 16:09

LeonMatthesKDAB reviewed Oct 21, 2024

View reviewed changes

ahayzen-kdab force-pushed the 882-add-qtypes branch from 709d25d to aec4f39 Compare November 5, 2024 17:45

ahayzen-kdab added 2 commits November 5, 2024 17:46

qtypes: add support for Qt alias types that don't match

05550dd

Some times don't match the Rust types so add these missing types. Closes KDAB#882

cxx-qt-lib: use qint64 type for QDate and QDateTime

1190bde

ahayzen-kdab force-pushed the 882-add-qtypes branch from aec4f39 to f2bf8e6 Compare November 5, 2024 17:46

cxx-qt-lib: use quintptr for QModelIndex

91759c2

ahayzen-kdab force-pushed the 882-add-qtypes branch from f2bf8e6 to 91759c2 Compare November 5, 2024 17:48

ahayzen-kdab commented Nov 5, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

qtypes: add support for Qt alias types that don't match #904

qtypes: add support for Qt alias types that don't match #904

ahayzen-kdab commented Mar 28, 2024

codecov bot commented Sep 5, 2024 •

edited

Loading

LeonMatthesKDAB left a comment

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

LeonMatthesKDAB Oct 21, 2024

ahayzen-kdab Nov 5, 2024

ahayzen-kdab Nov 5, 2024

qtypes: add support for Qt alias types that don't match #904

Are you sure you want to change the base?

qtypes: add support for Qt alias types that don't match #904

Conversation

ahayzen-kdab commented Mar 28, 2024

codecov bot commented Sep 5, 2024 • edited Loading

Codecov Report

LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 5, 2024 •

edited

Loading