feat: move compressed test data to files instead of base64 strings

KDAB · Nov 19, 2024 · 3e74a87 · 3e74a87
1 parent 06cfd33
commit 3e74a87
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 19 deletions.
diff --git a/tests/integrationtests/archives/test.bz2 b/tests/integrationtests/archives/test.bz2
diff --git a/tests/integrationtests/archives/test.gz b/tests/integrationtests/archives/test.gz
diff --git a/tests/integrationtests/archives/test.txt b/tests/integrationtests/archives/test.txt
@@ -0,0 +1 @@
+Hello World
diff --git a/tests/integrationtests/archives/test.xz b/tests/integrationtests/archives/test.xz
diff --git a/tests/integrationtests/tst_perfparser.cpp b/tests/integrationtests/tst_perfparser.cpp
@@ -798,34 +798,20 @@ private slots:
 #if KFArchive_FOUND
     void testDecompression_data()
     {
-        QTest::addColumn<QByteArray>("content");
         QTest::addColumn<QString>("filename");
 
-        QTest::newRow("plain") << QByteArrayLiteral("Hello World\n") << QStringLiteral("XXXXXX");
-        QTest::newRow("gzip") << QByteArray::fromBase64(
-            QByteArrayLiteral("H4sIAAAAAAAAA/NIzcnJVwjPL8pJ4QIA4+WVsAwAAAA="))
-                              << QStringLiteral("XXXXXX.gz");
-        QTest::newRow("bzip2") << QByteArray::fromBase64(
-            QByteArrayLiteral("QlpoOTFBWSZTWdhyAS8AAAFXgAAQQAAAQACABgSQACAAIgaG1CDJiMdp6Cgfi7kinChIbDkAl4A="))
-                               << QStringLiteral("XXXXXX.bz2");
-        QTest::newRow("xz") << QByteArray::fromBase64(QByteArrayLiteral(
-            "/Td6WFoAAATm1rRGAgAhARYAAAB0L+WjAQALSGVsbG8gV29ybGQKACLgdT/V7Tg+AAEkDKYY2NgftvN9AQAAAAAEWVo="))
-                            << QStringLiteral("XXXXXX.xz");
+        QTest::newRow("plain") << QFINDTESTDATA("archives/test.txt");
+        QTest::newRow("gzip") << QFINDTESTDATA("archives/test.gz");
+        QTest::newRow("bzip2") << QFINDTESTDATA("archives/test.bz2");
+        QTest::newRow("xz") << QFINDTESTDATA("archives/test.xz");
     }
 
     void testDecompression()
     {
-        QFETCH(QByteArray, content);
         QFETCH(QString, filename);
 
-        QTemporaryFile compressed;
-        compressed.setFileTemplate(filename);
-        compressed.open();
-        compressed.write(content);
-        compressed.close();
-
         PerfParser parser;
-        QFile decompressed(parser.decompressIfNeeded(compressed.fileName()));
+        QFile decompressed(parser.decompressIfNeeded(filename));
         decompressed.open(QIODevice::ReadOnly);
 
         QCOMPARE(decompressed.readAll(), QByteArrayLiteral("Hello World\n"));