Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero-size symbols were lost #252

Closed
dknysh opened this issue Sep 14, 2020 · 0 comments
Closed

Zero-size symbols were lost #252

dknysh opened this issue Sep 14, 2020 · 0 comments
Labels

Comments

@dknysh
Copy link
Contributor

dknysh commented Sep 14, 2020

Hello Milian,

We have faced with a lot of disappeared symbols from Hotspot output due to recent changes about
'Important performance optimization with building of sorted symtab for faster lookups' - Jul 2, 2020 commit fc12536.
I have noticed that there are not considered symbols with zero size and due this they disappeared.
The context is the following - we have some Java benchmarks contained many symbols from .so.
They have zero size and we just lost them at all after mentioned 'Performance optimization' changes.
I will send merge request with my suggestion to fix this.

Darya

@dknysh dknysh added the bug label Sep 14, 2020
milianw pushed a commit to KDAB/perfparser that referenced this issue Sep 25, 2020
Apparently there are situations where the compiler generates entries
in the symbol table with zero size which are still referenced by some
callstacks. After commit fc12536 we ended up losing the symbol names
in such cases. This patch fixes it again and restores the symbol names
for such zero-size symbols.

Fixes: KDAB/hotspot#252
Change-Id: Ib11521bc88f719811559d1e20f27c275eb8e5606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant