Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caller/callee: optional "extended" search #666

Closed
GitMensch opened this issue Jul 18, 2024 · 0 comments · Fixed by #676 · May be fixed by #674
Closed

caller/callee: optional "extended" search #666

GitMensch opened this issue Jul 18, 2024 · 0 comments · Fixed by #676 · May be fixed by #674

Comments

@GitMensch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Commonly I need to inspect the cost for multiple symbols.

Describe the solution you'd like
Allow the search to be "extended", for example when starting with a "+" then have the following word be an additional search like +symba +BSYM / symba||BSYM or even regex (possibly also triggered by a leading character that is unexpected to occur symbols like %l.

Describe alternatives you've considered
The current option is only to either filter the uninteresting symbols out (getting to the same result an extended/regex search would provide), or using the search multiple times and inspect each time separately.

lievenhey added a commit that referenced this issue Sep 17, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
lievenhey added a commit that referenced this issue Sep 17, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
lievenhey added a commit that referenced this issue Sep 17, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
lievenhey added a commit that referenced this issue Oct 10, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
lievenhey added a commit that referenced this issue Oct 10, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
lievenhey added a commit that referenced this issue Oct 10, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
milianw pushed a commit that referenced this issue Nov 18, 2024
Since we use QSortFilterProxyModel we get this for free.
This patch adds support for regex search by not escaping the search term
if it is prefix with %.
For the flamegraph there is a custom implementation, which changes the
current QString::contains to a QRegularExpression::match call.

Closes: #666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant