don't include non-working context-menu entries #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitMensch
force-pushed
the
cleanup-contextmenu
branch
from
ef3cecd
to
22d6f1c
Compare
milianw
requested changes
Nov 30, 2023
This data has no meaningful symbols and thus shouldn't show these actions at all.
Previously we incorrectly set the binary as symbol name which was obviously wrong and lead to confusion and hacky code in other places.
milianw
force-pushed
the
cleanup-contextmenu
branch
from
22d6f1c
to
9fdc433
Compare
milianw
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to 5d5df76
fixes #557
the biggest open question is: can we see in resultsutil.cpp which context we are in? In this case the filtering for "Top Hotspots per File" could be much easer and there's no need to change src/models/data.h
side note: I find it quite confusing that "binary only symbols" have the binary name in the symbol name and no binary name, maybe it would be good to change that and, if needed, add a flag "binaryOnly"?