Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vscode applications to the predefined IDEs for "Open in Editor" #606

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

GitMensch
Copy link
Contributor

@GitMensch GitMensch commented Feb 28, 2024

@dfaure may want to have a look at this, too, as he added the call to the code binary

  • added vscodium
  • have both vscode applications also available on Windows + MacOS

Question: Is it fine to push the suggested formatting change?

-    {"codium", "-g %f:%l:%c", QT_TRANSLATE_NOOP("MainWindow", "VSCodium"), "codium"}
-};
+    {"codium", "-g %f:%l:%c", QT_TRANSLATE_NOOP("MainWindow", "VSCodium"), "codium"}};

@GitMensch
Copy link
Contributor Author

And just a note to people interested - this also works fine when running HotSpot on remote environments when started from vscode terminal (both on WSL and SSH remotes).

@dfaure-kdab
Copy link
Member

Yes please apply the clang-format fix as well.

* added vscodium
* have both vscode applications also available on Windows + MacOS
@GitMensch
Copy link
Contributor Author

done

@dfaure-kdab dfaure-kdab merged commit 6f9f958 into KDAB:master Mar 4, 2024
13 checks passed
@GitMensch GitMensch deleted the patch-1 branch March 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants