Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more API to JsonDocument #31

Closed
narnaud opened this issue Jun 19, 2024 · 0 comments · May be fixed by #86
Closed

Add some more API to JsonDocument #31

narnaud opened this issue Jun 19, 2024 · 0 comments · May be fixed by #86
Assignees
@mgiroday
Labels
⬆️ feature New feature or request 🙋 good first issue Good for newcomers
Milestone
Release 1.0.0

Comments

@narnaud
Copy link
Member

narnaud commented Jun 19, 2024

This is a follow-up of #20.

Add some API to get or set a value from a JsonDocument. There are more likely some code that could be stolen from Settings, as it's doing exactly that (see hasValue/vlaue/setValue method). Ideally, consolidate those methods, so the code is shared between the 2 classes.

Add tests too.
@narnaud narnaud added ⬆️ feature New feature or request 🙋 good first issue Good for newcomers labels Jun 19, 2024
@narnaud narnaud added this to the Release 1.0.0 milestone Jun 19, 2024
@mgiroday mgiroday self-assigned this Jun 19, 2024
mgiroday added a commit to mgiroday/knut that referenced this issue Jun 28, 2024
@mgiroday
feat: Add some more API to JsonDocument
61b4dc1 
Issue KDAB#31
mgiroday added a commit to mgiroday/knut that referenced this issue Aug 12, 2024
@mgiroday
feat: Add some more API to JsonDocument
7e5b9dd 
Issue KDAB#31
mgiroday added a commit to mgiroday/knut that referenced this issue Aug 13, 2024
@mgiroday
feat: Add some more API to JsonDocument
670c2c2 
Issue KDAB#31
mgiroday added a commit to mgiroday/knut that referenced this issue Aug 21, 2024
@mgiroday
feat: Add some more API to JsonDocument
9f89915 
Issue KDAB#31
mgiroday added a commit to mgiroday/knut that referenced this issue Aug 23, 2024
@mgiroday
feat: Add some more API to JsonDocument
463ab4a 
Issue KDAB#31
mgiroday added a commit that referenced this issue Aug 23, 2024
@mgiroday
feat: Add some more API to JsonDocument (#76)
2559458 
Issue #31
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgiroday mgiroday

Labels
⬆️ feature New feature or request 🙋 good first issue Good for newcomers
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

chore(main): release 1.0.0 KDAB/knut
2 participants
@narnaud @mgiroday