Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Knut.Test all together #49

Closed
3 tasks
narnaud opened this issue Jun 22, 2024 · 1 comment
Closed
3 tasks

Remove Knut.Test all together #49

narnaud opened this issue Jun 22, 2024 · 1 comment
Assignees
@LeonMatthesKDAB
Labels
🙋 good first issue Good for newcomers 👷 refactor Something needs to change ❌ wontfix This will not be worked on
Milestone
Release 1.0.0

Comments

@narnaud
Copy link
Member

narnaud commented Jun 22, 2024 •
edited
Loading

We don't need that anymore, there's a TestCase directly in Qt using QTest:
https://doc.qt.io/qt-6/qml-qttest-testcase.html

  • refactor the test-data/tst_*.qml to use QTest
  • move the static methods from core/TestUtil to test_utils.h (they are not used anymore in the QML files
  • remove TestUtil and TestCase.qml from core
@narnaud narnaud added 🙋 good first issue Good for newcomers 👷 refactor Something needs to change labels Jun 22, 2024
@narnaud narnaud changed the title Remove TestCase.qml Remove Script.Test all together Jun 22, 2024
@narnaud narnaud mentioned this issue Jun 22, 2024
Closed
2 tasks
@narnaud narnaud added this to the Release 1.0.0 milestone Jun 22, 2024
@LeonMatthesKDAB LeonMatthesKDAB changed the title Remove Script.Test all together Remove Knut.Test all together Jul 9, 2024
@LeonMatthesKDAB LeonMatthesKDAB self-assigned this Jul 9, 2024
LeonMatthesKDAB added a commit to LeonMatthesKDAB/knut that referenced this issue Jul 9, 2024
@LeonMatthesKDAB
refactor!: Remove Knut.Test
21c3c07 
We can replace this with QtTest in Qt6.

Fix KDAB#49
@LeonMatthesKDAB LeonMatthesKDAB mentioned this issue Jul 9, 2024
Closed
LeonMatthesKDAB added a commit to LeonMatthesKDAB/knut that referenced this issue Jul 9, 2024
@LeonMatthesKDAB
refactor!: Remove Knut.Test
1f52727 
We can replace this with QtTest in Qt6.

Fix KDAB#49
@LeonMatthesKDAB
Copy link
Collaborator

Abandon for now, as explained in #96

@LeonMatthesKDAB LeonMatthesKDAB added the ❌ wontfix This will not be worked on label Jul 9, 2024
narnaud added a commit to narnaud/knut that referenced this issue Jul 10, 2024
@narnaud
refactor!: Change the test API for scripts
a634a6a 
This change generalize the `test` function for script, allowing to have multiple test functions.
Also remove the Knut.Test module, not needed anymore.

This makes the whole testing more streamline, and easier to work with.

- remove the `Knut.Test` module and `TestCase` item
- add `compare` and `verify` to `Script` and `ScriptDialog`
- run all methods starting with `test_` in test mode
- don't run `test` anymore (breaking change here), as it does not make sense to have a special case for this.

Related to KDAB#49
@narnaud narnaud mentioned this issue Jul 10, 2024
Merged
narnaud added a commit to narnaud/knut that referenced this issue Jul 10, 2024
@narnaud
refactor!: Change the test API for scripts
a6235a3 
This change generalize the `test` function for script, allowing to have multiple test functions.
Also remove the Knut.Test module, not needed anymore.

This makes the whole testing more streamline, and easier to work with.

- remove the `Knut.Test` module and `TestCase` item
- add `compare` and `verify` to `Script` and `ScriptDialog`
- run all methods starting with `test_` in test mode
- don't run `test` anymore (breaking change here), as it does not make sense to have a special case for this.

Related to KDAB#49
narnaud added a commit to narnaud/knut that referenced this issue Jul 10, 2024
@narnaud
refactor!: Change the test API for scripts
06a3a58 
This change generalize the `test` function for script, allowing to have multiple test functions.
Also remove the Knut.Test module, not needed anymore.

This makes the whole testing more streamline, and easier to work with.

- remove the `Knut.Test` module and `TestCase` item
- add `compare` and `verify` to `Script` and `ScriptDialog`
- run all methods starting with `test_` in test mode
- don't run `test` anymore (breaking change here), as it does not make sense to have a special case for this.

Related to KDAB#49
narnaud added a commit that referenced this issue Jul 10, 2024
@narnaud
refactor!: Change the test API for scripts
cf7f514 
This change generalize the `test` function for script, allowing to have multiple test functions.
Also remove the Knut.Test module, not needed anymore.

This makes the whole testing more streamline, and easier to work with.

- remove the `Knut.Test` module and `TestCase` item
- add `compare` and `verify` to `Script` and `ScriptDialog`
- run all methods starting with `test_` in test mode
- don't run `test` anymore (breaking change here), as it does not make sense to have a special case for this.

Related to #49
smnppKDAB added a commit to smnppKDAB/knut that referenced this issue Jul 29, 2024
@smnppKDAB
fix: simplify the API documentation
d344e5f 
Fixes KDAB#50

This is a follow up of KDAB#49.
- remove all "\inqmlmodule in the code documentation
- add an empty string into Script module to be able to use it, just in case for later
@smnppKDAB smnppKDAB mentioned this issue Jul 29, 2024
Merged
smnppKDAB added a commit to smnppKDAB/knut that referenced this issue Jul 30, 2024
@smnppKDAB
fix: simplify the API documentation
21dc223 
Fixes KDAB#50

This is a follow up of KDAB#49.
- remove all "\inqmlmodule in the code documentation
- add an empty string into Script module to be able to use it, just in case for later
smnppKDAB added a commit to smnppKDAB/knut that referenced this issue Jul 30, 2024
@smnppKDAB
fix: simplify the API documentation
005d5bc 
Fixes KDAB#50

This is a follow up of KDAB#49.
- remove all "\inqmlmodule in the code documentation
- add an empty string into Script module to be able to use it, just in case for later
smnppKDAB added a commit to smnppKDAB/knut that referenced this issue Jul 30, 2024
@smnppKDAB
fix: simplify the API documentation
d0bda3c 
Fixes KDAB#50

This is a follow up of KDAB#49.
- remove all "\inqmlmodule in the code documentation
- add an empty string into Script module to be able to use it, just in case for later
dfaure-kdab pushed a commit that referenced this issue Jul 30, 2024
@smnppKDAB
fix: simplify the API documentation (#132)
147fe34 
Fixes #50

This is a follow up of #49.
- remove all "\inqmlmodule in the code documentation
- add an empty string into Script module to be able to use it, just in case for later
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonMatthesKDAB LeonMatthesKDAB

Labels
🙋 good first issue Good for newcomers 👷 refactor Something needs to change ❌ wontfix This will not be worked on
Projects
None yet
Milestone
Release 1.0.0
Development

Successfully merging a pull request may close this issue.

refactor!: Remove Knut.Test LeonMatthesKDAB/knut
2 participants
@narnaud @LeonMatthesKDAB