Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not create new files from the palette #216

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

narnaud
Copy link
Member

@narnaud narnaud commented Nov 12, 2024

The palette is just a way to navigate around, it shouldn't be able to
create new files.
Also keep the palette open if the text does not match (like VS Code).

Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have to admit it took me quite a while to figure out how this prevents new file creation.

I would really appreciate some better documentation there.

The palette is just a way to navigate around, it shouldn't be able to
create new files.
Also keep the palette open if the text does not match (like VS Code).
@narnaud narnaud force-pushed the fix-palette-create-files branch from 6658ff0 to e1ff841 Compare November 14, 2024 18:26
@narnaud narnaud merged commit e1d7e28 into KDAB:main Nov 17, 2024
5 checks passed
@narnaud narnaud deleted the fix-palette-create-files branch November 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants