lints and changelog

KGrewal1 · Jan 7, 2024 · 054735f · 054735f
1 parent c6f22cf
commit 054735f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/Changelog.md b/Changelog.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## v0.3.2 (2024-01-02)
+
+* move directional evaluation into stronge wolfe
+* fix strong wolfe condition when used with weight decay
+
 ## v0.3.1 (2023-12-20)
 
 * Improved Documentation

diff --git a/src/lbfgs/strong_wolfe.rs b/src/lbfgs/strong_wolfe.rs
@@ -402,11 +402,11 @@ impl<M: Model> Lbfgs<M> {
                     .vars
                     .iter()
                     .map(|v| -> CResult<f64> {
-                        Ok(v.as_tensor()
+                        v.as_tensor()
                             .sqr()?
                             .sum_all()?
                             .to_dtype(candle_core::DType::F64)?
-                            .to_scalar::<f64>()?)
+                            .to_scalar::<f64>()
                     })
                     .sum::<CResult<f64>>()?
         } else {
@@ -429,11 +429,11 @@ impl<M: Model> Lbfgs<M> {
                     .vars
                     .iter()
                     .map(|v| -> CResult<f64> {
-                        Ok(v.as_tensor()
+                        v.as_tensor()
                             .sqr()?
                             .sum_all()?
                             .to_dtype(candle_core::DType::F64)?
-                            .to_scalar::<f64>()?)
+                            .to_scalar::<f64>()
                     })
                     .sum::<CResult<f64>>()?)
         } else {