Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs audit for credentials section #317

Merged
merged 28 commits into from
Jul 19, 2024
Merged

Docs audit for credentials section #317

merged 28 commits into from
Jul 19, 2024

Conversation

ChrisChinchilla
Copy link
Contributor

No description provided.

@ChrisChinchilla
Draft
9d885ab 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Update
3002205 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Draft
718f86e 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Draft
4830222 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review July 2, 2024 11:17
@kilted-andres kilted-andres self-requested a review July 2, 2024 16:29
kilted-andres
kilted-andres requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@kilted-andres kilted-andres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like most of your additions.

This is just a partial review, because I'm to picky and ergo slow.

docs/concepts/05_credentials/01_overview.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/01_overview.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/01_overview.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/01_overview.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/02_ctypes.md Show resolved Hide resolved
kilted-andres
kilted-andres requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@kilted-andres kilted-andres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good.

I'm done with the review now.

I think that section about the published credentials is necessary though.

docs/concepts/05_credentials/03_claiming.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/03_claiming.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/03_claiming.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/04_attestation.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/05_verification.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/05_verification.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/05_verification.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/05_verification.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/06_public_credentials.md Show resolved Hide resolved
docs/concepts/05_credentials/06_public_credentials.md Show resolved Hide resolved
ChrisChinchilla and others added 19 commits July 4, 2024 10:48
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
35adf52 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
8a01588 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/02_ctypes.md
dbc8b93 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla
Update docs/concepts/05_credentials/03_claiming.md
3ff65da
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/02_ctypes.md
070923c 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
f30ea96 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
c3d8556 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
a3d5328 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
6cfde3f 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/03_claiming.md
795b4e7 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla
Changes
113e0d0 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Merge branch 'chrisward/next-level-concepts' of github.com:KILTprotoc…
77b3e1a 
…ol/docs into chrisward/next-level-concepts-credentials
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/05_verification.md
5383928 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla
Draft
d070f66 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Merge branch 'chrisward/next-level-concepts' of github.com:KILTprotoc…
0701698 
…ol/docs into chrisward/next-level-concepts-credentials
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/05_verification.md
28771db 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla
Changes
f343ef8 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Merge branch 'chrisward/next-level-concepts' of github.com:KILTprotoc…
74e9040 
…ol/docs into chrisward/next-level-concepts-credentials
@ChrisChinchilla
Change
46a9339 
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@aws-amplify-eu-central-1 AWS Amplify (eu-central-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-317.d3oeht7cvddn19.amplifyapp.com

kilted-andres
kilted-andres approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@kilted-andres kilted-andres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a new suggestion. Besides that, everything is great.

I give you the approval already. 🥳

docs/concepts/05_credentials/01_overview.md Outdated Show resolved Hide resolved
docs/concepts/05_credentials/05_verification.md Outdated Show resolved Hide resolved
ChrisChinchilla and others added 2 commits July 19, 2024 12:02
@ChrisChinchilla @kilted-andres
Update docs/concepts/05_credentials/01_overview.md
09cbea0 
Co-authored-by: Andrés <105802444+kilted-andres@users.noreply.github.com>
@ChrisChinchilla
Update docs/concepts/05_credentials/05_verification.md
6b21876
@ChrisChinchilla ChrisChinchilla merged commit cdf7e80 into master Jul 19, 2024
1 of 6 checks passed
@ChrisChinchilla ChrisChinchilla deleted the chrisward/next-level-concepts branch July 19, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilted-andres kilted-andres kilted-andres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisChinchilla @kilted-andres