Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polar path documentation #319

Merged
merged 24 commits into from
Oct 15, 2024
Merged

Conversation

ChrisChinchilla
Copy link
Contributor

@ChrisChinchilla ChrisChinchilla commented Jul 9, 2024

fixes KILTProtocol/ticket#3472

Adds Polar path documentation

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Copy link
Contributor Author

@ntn-x2 Pretty rough draft and I want to get your input on a few things in particular, but for the general structure, what are initial thoughts?

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-319.d3oeht7cvddn19.amplifyapp.com

Signed-off-by: Chris Chinchilla <chris@kilt.io>
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
docs/develop/09_polarpath/01_overview.md Outdated Show resolved Hide resolved
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ntn-x2
Copy link
Member

ntn-x2 commented Aug 5, 2024

@ChrisChinchilla what's the status of this PR?

Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Copy link
Contributor Author

Build will currently fail as the path doesn't exist yet.

Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Copy link
Contributor Author

@ntn-x2 Ready again, and we also have the node autogenerated docs if needed, but it looks like the comments generally refer people to the read me / docs anyway.

@ntn-x2
Copy link
Member

ntn-x2 commented Aug 29, 2024

Hey, build is failing. Otherwise changes look ok to me.

Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ntn-x2
Copy link
Member

ntn-x2 commented Oct 11, 2024

@ChrisChinchilla can you look into the CI status please? Thank you.

@ChrisChinchilla
Copy link
Contributor Author

@ntn-x2 I'll check, but a lot of the tests are getting replaced due to the SDK changes in other PRs anyway, so I'll check why it's not building, but it may not be worth fixing the code examples in this PR.

Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla
Copy link
Contributor Author

@ntn-x2 The latest push fixes the paths if I take the file from develop; if you think it needs to be from the release branch, I need to think a bit more; in those branches, the link is incorrect.

@ntn-x2
Copy link
Member

ntn-x2 commented Oct 15, 2024

@ChrisChinchilla the fixes will anyway be included in the next release, so please just make a ticket reminding us to replace develop with the next release branch, and provide a brief explanation as a context for the ticket. Then, we can go ahead and merge this targeting develop at the moment.

@ChrisChinchilla
Copy link
Contributor Author

@ChrisChinchilla ChrisChinchilla merged commit e622d71 into master Oct 15, 2024
2 of 6 checks passed
@ChrisChinchilla ChrisChinchilla deleted the 3472-polar-path-documentation branch October 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants