-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polar path documentation #319
Conversation
@ntn-x2 Pretty rough draft and I want to get your input on a few things in particular, but for the general structure, what are initial thoughts? |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
…ol/docs into 3472-polar-path-documentation
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla what's the status of this PR? |
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Build will currently fail as the path doesn't exist yet. |
@ntn-x2 Ready again, and we also have the node autogenerated docs if needed, but it looks like the comments generally refer people to the read me / docs anyway. |
Hey, build is failing. Otherwise changes look ok to me. |
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ChrisChinchilla can you look into the CI status please? Thank you. |
@ntn-x2 I'll check, but a lot of the tests are getting replaced due to the SDK changes in other PRs anyway, so I'll check why it's not building, but it may not be worth fixing the code examples in this PR. |
Signed-off-by: Chris Chinchilla <chris@kilt.io>
@ntn-x2 The latest push fixes the paths if I take the file from develop; if you think it needs to be from the release branch, I need to think a bit more; in those branches, the link is incorrect. |
@ChrisChinchilla the fixes will anyway be included in the next release, so please just make a ticket reminding us to replace |
fixes KILTProtocol/ticket#3472
Adds Polar path documentation
Checklist: