3595 terminology changes inline with w3c standards #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Chinchilla <chris@kilt.io>
Signed-off-by: Chris Chinchilla <chris@kilt.io>
rflechtner
reviewed
Sep 9, 2024
code_examples/sdk_examples/src/workshop/issuer/generateAccount.ts
Outdated
Show resolved
Hide resolved
| @@ -35,7 +35,7 @@ CLIENT_SPEC=$(cat <<EOF | |||
| { | |||
| "requirements": [{ | |||
| "cTypeHash":"0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac", | |||
| "trustedAttesters": [ | |||
| "trustedIssuers": [ | |||
There was a problem hiding this comment.
this relates to a configuration of openDid and shouldn't be changed without changing the openDid code base first
static/img/concepts/distributed_trust/delegation-hierarchies-dark.svg
Outdated
Show resolved
Hide resolved
|
the language changes make sense to me, but there's a few changes that don't seem right - like lots of packages being downgraded (including the sdk from v1 to 0.35.0), some other reverts back to code we had in v0, and some renames that shouldn't have happened |
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
Co-authored-by: Raphael Flechtner <39338561+rflechtner@users.noreply.github.com>
ChrisChinchilla
deleted the
3595-terminology-changes-inline-with-w3c-standards
branch
ChrisChinchilla
restored the
3595-terminology-changes-inline-with-w3c-standards
branch
ChrisChinchilla
deleted the
3595-terminology-changes-inline-with-w3c-standards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3595