fix: rm Default requirement for AccountId types

KILTprotocol · Feb 25, 2022 · a673dfe · a673dfe
1 parent e3aa793
commit a673dfe
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 6 deletions.
diff --git a/pallets/did/src/lib.rs b/pallets/did/src/lib.rs
@@ -192,7 +192,7 @@ pub mod pallet {
 			+ DeriveDidCallAuthorizationVerificationKeyRelationship;
 
 		/// Type for a DID subject identifier.
-		type DidIdentifier: Parameter + Default + DidVerifiableIdentifier + MaxEncodedLen;
+		type DidIdentifier: Parameter + DidVerifiableIdentifier + MaxEncodedLen;
 
 		/// Origin type expected by the proxied dispatchable calls.
 		#[cfg(not(feature = "runtime-benchmarks"))]

diff --git a/pallets/did/src/origin.rs b/pallets/did/src/origin.rs
@@ -39,8 +39,6 @@ impl<OuterOrigin, DidIdentifier, AccountId> EnsureOrigin<OuterOrigin> for Ensure
 where
 	OuterOrigin: Into<Result<DidRawOrigin<DidIdentifier, AccountId>, OuterOrigin>>
 		+ From<DidRawOrigin<DidIdentifier, AccountId>>,
-	DidIdentifier: Default,
-	AccountId: Default,
 {
 	type Success = DidRawOrigin<DidIdentifier, AccountId>;
 

diff --git a/pallets/pallet-did-lookup/src/lib.rs b/pallets/pallet-did-lookup/src/lib.rs
@@ -85,7 +85,7 @@ pub mod pallet {
 		type OriginSuccess: CallSources<AccountIdOf<Self>, DidIdentifierOf<Self>>;
 
 		/// The identifier to which accounts can get associated.
-		type DidIdentifier: Parameter + Default + MaxEncodedLen;
+		type DidIdentifier: Parameter + MaxEncodedLen;
 
 		/// The currency that is used to reserve funds for each did.
 		type Currency: ReservableCurrency<AccountIdOf<Self>>;

diff --git a/pallets/pallet-web3-names/src/lib.rs b/pallets/pallet-web3-names/src/lib.rs
@@ -118,7 +118,7 @@ pub mod pallet {
 			+ TryFrom<Vec<u8>, Error = Error<Self>>
 			+ MaxEncodedLen;
 		/// The type of a name owner.
-		type Web3NameOwner: Parameter + Default + MaxEncodedLen;
+		type Web3NameOwner: Parameter + MaxEncodedLen;
 		/// Weight information for extrinsics in this pallet.
 		type WeightInfo: WeightInfo;
 	}

diff --git a/support/src/mock.rs b/support/src/mock.rs
@@ -112,7 +112,7 @@ pub mod mock_origin {
 	}
 }
 
-#[derive(Debug, Clone, PartialEq, Eq, Encode, Decode, TypeInfo, Default, MaxEncodedLen)]
+#[derive(Debug, Clone, PartialEq, Eq, Encode, Decode, TypeInfo, MaxEncodedLen)]
 pub struct SubjectId(pub AccountId32);
 
 impl From<AccountId32> for SubjectId {