Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to Polkadot v0.9.25 #381

Merged
merged 1 commit into from
Jul 14, 2022
Merged

feat: upgrade to Polkadot v0.9.25 #381

merged 1 commit into from
Jul 14, 2022

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Jul 13, 2022 •
edited
Loading

fixes KILTProtocol/ticket#2087

  • Upgrades to latest Polkadot v0.9.25
  • Removes Launch Pallet removal migration
  • No migrations required since we don't use Parity DB

Noteworthy PRs from Substrate that influenced changes:

Checklist:

  • I have verified that the code works
    • No panics! (checked arithmetic ops, no indexing array[3] use get(3), ...)
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@wischli wischli requested review from weichweich, ntn-x2 and trusch July 13, 2022 09:47
ntn-x2
ntn-x2 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trusch
Copy link
Contributor

trusch commented Jul 14, 2022

I think paritytech/substrate#11431 is worth mentioning. It enables the storage transaction support for all extrinsics if I understand it right, so we don't have to take care of strictly first checking everything and then writing to storage.

@wischli wischli merged commit d8af5d1 into develop Jul 14, 2022
@wischli wischli deleted the wf/polkadot-v0.9.25 branch July 14, 2022 13:39
wischli added a commit that referenced this pull request Aug 30, 2022
@wischli
feat: upgrade to Polkadot v0.9.25 (#381)
b59456e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weichweich weichweich weichweich approved these changes

@ntn-x2 ntn-x2 ntn-x2 approved these changes

@trusch trusch trusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wischli @trusch @ntn-x2 @weichweich