Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: polkadot 0.9.41 #519

Merged
merged 7 commits into from
May 23, 2023
Merged

chore: polkadot 0.9.41 #519

merged 7 commits into from
May 23, 2023

Conversation

Ad96el
Copy link
Member

@Ad96el Ad96el commented May 17, 2023

fixes ticket and fixes ticket

@ntn-x2 The RelayChainError enum has no ServiceError anymore. So I reverted it to the previous state.

Most important changes

  • Some pallets got a renaming (sc-finality-grandpa to sc-consensus-grandpa and sp-finality-grandpa to sp-consensus-grandpa).
  • Weight::from_ref_time and Weight::from_proof_size are deprecated now.
  • Extract syncing protocol

All changes for version 0.9.40 can be found here.

Version 0.9.41 is a client-only release.

@Ad96el Ad96el requested review from weichweich and ntn-x2 May 17, 2023 08:33
@Ad96el Ad96el changed the title Chore/polkadot 0.9.41 chore: polkadot 0.9.41 May 17, 2023
@@ -179,7 +179,6 @@ pub mod pallet {
}

#[pallet::pallet]
#[pallet::generate_store(pub(super) trait Store)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The storage getter was also deprecated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage getters seem to still be in. The PR was partially fixing the ticket, so I guess the deprecation of the storage getters will come in a next release.

Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr gut! 🚀🚀🚀

@Ad96el Ad96el merged commit f8d9d04 into develop May 23, 2023
@Ad96el Ad96el deleted the chore/polkadot-0.9.41 branch May 23, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants