fix: configure DIP templates BlockNumber to u64 #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
changed the title
…lt-node into aa/consumer-template-fix
weichweich
approved these changes
Dec 19, 2023
Ad96el
pushed a commit
that referenced
this pull request
Jan 10, 2024
DIP consumers are specific to a given provider. Right now, the template provider uses `u32` as block numbers, while `Peregrine` uses `u64`. This means that it is not possible to use a single consumer runtime (hence Docker image) to test both providers. The issue is fixed by making the provider template use the same block number type as Peregrine, so we can "stretch" it to be used in integration tests against the template consumer without having to have two different consumer runtimes and Docker images. To keep it consistent (although it is not required), I also changed the consumer runtime to use `u64`s. Integration tests with the DIP-SDK are finally passing. You can run them yourself following the instructions below. ## Checklist - [x] Apply change - [x] Build and push temp Docker images - [x] Verify integration tests for same template consumer work with both template provider and Peregrine - [ ] Review PR ## How to test * Clone the [DIP-SDK repo at this branch for PR #3](KILTprotocol/dip-sdk#3) * Set the env variables in `tests/peregrine-dip-consumer-template/.env.develop.test` for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and in `tests/dip-provider-template-dip-consumer-template/.env.develop.test` for `PROVIDER_IMAGE` to `kiltprotocol/dip-provider-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc`. * Run `yarn test:e2e:start-network:peregrine-provider:develop` to spin up the Zombienet network for Peregrine <-> DIP consumer * In a different bash, run `yarn test:e2e:peregrine-provider` to run the integration tests * Same thing with `yarn test:e2e:start-network:dip-template-provider:develop` and `yarn test:e2e:dip-template-provider`.
Ad96el
pushed a commit
that referenced
this pull request
Feb 7, 2024
DIP consumers are specific to a given provider. Right now, the template provider uses `u32` as block numbers, while `Peregrine` uses `u64`. This means that it is not possible to use a single consumer runtime (hence Docker image) to test both providers. The issue is fixed by making the provider template use the same block number type as Peregrine, so we can "stretch" it to be used in integration tests against the template consumer without having to have two different consumer runtimes and Docker images. To keep it consistent (although it is not required), I also changed the consumer runtime to use `u64`s. Integration tests with the DIP-SDK are finally passing. You can run them yourself following the instructions below. ## Checklist - [x] Apply change - [x] Build and push temp Docker images - [x] Verify integration tests for same template consumer work with both template provider and Peregrine - [ ] Review PR ## How to test * Clone the [DIP-SDK repo at this branch for PR #3](KILTprotocol/dip-sdk#3) * Set the env variables in `tests/peregrine-dip-consumer-template/.env.develop.test` for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and in `tests/dip-provider-template-dip-consumer-template/.env.develop.test` for `PROVIDER_IMAGE` to `kiltprotocol/dip-provider-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc`. * Run `yarn test:e2e:start-network:peregrine-provider:develop` to spin up the Zombienet network for Peregrine <-> DIP consumer * In a different bash, run `yarn test:e2e:peregrine-provider` to run the integration tests * Same thing with `yarn test:e2e:start-network:dip-template-provider:develop` and `yarn test:e2e:dip-template-provider`.
Ad96el
pushed a commit
that referenced
this pull request
Apr 2, 2024
DIP consumers are specific to a given provider. Right now, the template provider uses `u32` as block numbers, while `Peregrine` uses `u64`. This means that it is not possible to use a single consumer runtime (hence Docker image) to test both providers. The issue is fixed by making the provider template use the same block number type as Peregrine, so we can "stretch" it to be used in integration tests against the template consumer without having to have two different consumer runtimes and Docker images. To keep it consistent (although it is not required), I also changed the consumer runtime to use `u64`s. Integration tests with the DIP-SDK are finally passing. You can run them yourself following the instructions below. ## Checklist - [x] Apply change - [x] Build and push temp Docker images - [x] Verify integration tests for same template consumer work with both template provider and Peregrine - [ ] Review PR ## How to test * Clone the [DIP-SDK repo at this branch for PR #3](KILTprotocol/dip-sdk#3) * Set the env variables in `tests/peregrine-dip-consumer-template/.env.develop.test` for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and in `tests/dip-provider-template-dip-consumer-template/.env.develop.test` for `PROVIDER_IMAGE` to `kiltprotocol/dip-provider-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc` and for `CONSUMER_IMAGE` to `kiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc`. * Run `yarn test:e2e:start-network:peregrine-provider:develop` to spin up the Zombienet network for Peregrine <-> DIP consumer * In a different bash, run `yarn test:e2e:peregrine-provider` to run the integration tests * Same thing with `yarn test:e2e:start-network:dip-template-provider:develop` and `yarn test:e2e:dip-template-provider`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIP consumers are specific to a given provider. Right now, the template provider uses
u32as block numbers, whilePeregrineusesu64. This means that it is not possible to use a single consumer runtime (hence Docker image) to test both providers. The issue is fixed by making the provider template use the same block number type as Peregrine, so we can "stretch" it to be used in integration tests against the template consumer without having to have two different consumer runtimes and Docker images. To keep it consistent (although it is not required), I also changed the consumer runtime to useu64s.Integration tests with the DIP-SDK are finally passing. You can run them yourself following the instructions below.
Checklist
How to test
tests/peregrine-dip-consumer-template/.env.develop.testforCONSUMER_IMAGEtokiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6ccand intests/dip-provider-template-dip-consumer-template/.env.develop.testforPROVIDER_IMAGEtokiltprotocol/dip-provider-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6ccand forCONSUMER_IMAGEtokiltprotocol/dip-consumer-node-template:dev-release-48c2c610d7c6a91f9c1579c8a93d12c59b35b6cc.yarn test:e2e:start-network:peregrine-provider:developto spin up the Zombienet network for Peregrine <-> DIP consumeryarn test:e2e:peregrine-providerto run the integration testsyarn test:e2e:start-network:dip-template-provider:developandyarn test:e2e:dip-template-provider.