feat: bonded coins pallet #726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ad96el
reviewed
Sep 12, 2024
| use frame_benchmarking::{benchmarks, impl_benchmark_test_suite, whitelisted_caller}; | ||
| use frame_system::RawOrigin; | ||
|
|
||
| benchmarks! { |
There was a problem hiding this comment.
We should use the benchmarking v2 here. I know it's not the time yet. I just wanted to bring it up here
|
|
||
| // TODO: apply lock if pool_details.transferable != true | ||
|
|
||
| Ok(().into()) |
There was a problem hiding this comment.
can be removed with DispatchResult
… into feat-bonded-coins
Implements bonding curve based token burning. Refactors the get_cost associated function to do so. Co-authored-by: Adel Golghalyani <ad96el@gmail.com>
|
Superseded by #764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#3585
Draft PR for the bonded currencies pallet, part of our efforts to bring VCOs to the KILT network.
Metadata Diff to Develop Branch
Peregrine Diff
Spiritnet Diff
Checklist:
array[3]useget(3), ...)