chore: Update to Substrate v2.0.0-rc4 #81

weichweich · 2020-03-26T09:50:49Z

Update to Substrate 2.0.0

fixes KILTProtocol/ticket#533
closes KILTprotocol/ticket/issues/549
closes KILTprotocol/ticket/issues/406

ToDos

update the chain specs
"Restore" v1.0 payment fees
Remove weight?
The block time after the update is 6s, it should be 10s.
- it should be configured in the genesis block?!
What was the index for? Do we need an index?

How to test:

Checklist:

I have verified that the code works
I have verified that the code is easy to understand
- If not, I have left a well-balanced amount of inline comments
I have left the code in a better state
I have documented the changes (where applicable)

weichweich · 2020-06-09T06:49:52Z

before the update is merged we need to update the chain specs! 😱

runtime/src/ctype/tests.rs

we can now get the next tx nonce with respect to the tx pool closes KILTprotocol/ticket/issues/549

closes KILTprotocol/ticket/issues/406

wischli

LGTM

rflechtner

shrug
I have two commentses !

rflechtner · 2020-06-24T14:27:16Z

Dockerfile

-COPY ./scripts/build.sh /scripts/build.sh
-RUN /bin/bash /scripts/build.sh
-
-# this container builds the mashnet-node binary from source files, the runtime library and the WASM file built previously
 FROM rustlang/rust@sha256:9ac425a47e25a7a5dac999362b89de2b91b21ce70c557a409c46280393f7b1f1 as builder


currently checking whether the latest rust:nightly can compile it

it can! so I'd suggest we go back to rustlang/rust:nightly

Or we could also use the Parity rust image paritytech/ci-linux:production which we already use in the Portablegabi Node. This used to be called paritytech/rust-builder.

rflechtner · 2020-06-24T15:09:48Z

src/command.rs

+// Copyright 2017-2020 Parity Technologies (UK) Ltd.
+// This file is part of Substrate.
+
+// Substrate is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Substrate is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Substrate. If not, see <http://www.gnu.org/licenses/>.


figure out what to do with this license header

@weichweich Remove it?

@weichweich Remove it?

I guess GPL doesn't allow that. Just keep it. We may be able to add our copyright to the one of parity?

// Copyright 2017-2020 Parity Technologies (UK) Ltd. // Copyright 2019-2020 Botlabs GmbH

Or something like that...

I like that. We should check with @GustavHemmelmayr.

well, comirights for two companies for same software is confusing unless we really programmed together - stuff that is done by us can be labled for BOTLabs GmbH (please spell with the first three letters as capital letters) and stuff that is done by Parity is labeld by them and we just refer to it, right?

GPL does allow a reference to the company, please always use the original wording in the license part of the software.

tjwelde · 2020-06-25T13:09:10Z

src/chain_spec.rs

- x25519::Public::from_raw(hex!("d660b4470a954ecc99496d4e4b012ee9acac3979e403967ef09de20da9bdeb28")),
- x25519::Public::from_raw(hex!("2ecb6a4ce4d9bc0faab70441f20603fcd443d6d866e97c9e238a2fb3e982ae2f")),
- ],
+ get_authority_keys_from_seed("0x58d3bb9e9dd245f3dec8d8fab7b97578c00a10cf3ca9d224caaa46456f91c46c"),


This is supposed to be a public key

fixed in 8d75804

Have a look at how polkadot is doing it: https://github.com/paritytech/polkadot/blob/848e1a892f99c16015b75117fdae00b393cde770/service/src/chain_spec.rs#L365
Can't we do it similarly?

runtime/src/lib.rs

tjwelde · 2020-06-25T13:19:02Z

runtime/src/lib.rs

+ impl_name: create_runtime_str!("mashnet-node"),
+ authoring_version: 4,
+ spec_version: 4,
+ impl_version: 5,


Can this start at 0/1 again?

We should not.

Me asking on Substrate builder's channel.

Short question about the incrementing of the runtime version. What would be the recommended best practice when we switch from Substrate 1.x to 2.0?

Increment all version numbers

"Reset" to 1 if current versions > 1

Jam from Parity

It only really matters if you have external tooling pointing to your chains and you have some kind of continuity of the infrastructure between versions. I generally don't think it's a good idea to go backwards in version number unless you are changing the name or something.

Not sure, if he did understand the questions correctly. We only want to put impl_version to 1, while increasing authoring_version and spec_version.
Like going from 0.2.8 to 0.3.0.
But we actually do not have the restrictions, he is talking about, so I guess it doesn't matter. Would still be interesting to know, how it is supposed to be done.

Gav said something about this: paritytech/substrate#241

Also only really matters, when updating the runtime on-chain.

Don't use public keys as secret seeds when building account IDs

tjwelde · 2020-06-26T12:38:32Z

LGTM

rflechtner and others added 9 commits March 4, 2020 14:12

chore: fixed a few more lint errors missed earlier

444714e

chore: codestyle

be43a22

wip

2dc599b

feat: cargo workspace

142ede3

wip: update dependencies

35ea242

wip: fix deposit_event

5d5de1e

wip: fix map

eb7a549

chore: match dependencies with substrate template

a57454e

chore: set correct dependency names

28507a8

weichweich force-pushed the wip-v2.0.0 branch from c66bc9f to 28507a8 Compare March 26, 2020 13:07

weichweich and others added 20 commits March 26, 2020 15:03

wip: use crates.io in runtime

2f96c8f

wip: use new build.rs

7ab2d2f

wip: fix std feature

578e871

fix: dispatch errors in mod files

d18f3ae

fix: prints

9d0b770

wip: fix mod errors from sp_primitives

a0fa429

wip: add wasm thing and sp-api

4438dc7

wip: fixed lib.rs?

e3d4244

wip: fix codec

75c12e7

chore: clean up old files

a7591a4

wip: fix identity thing

56667a2

wip: fix error modules

2bb36e9

wip: fix init call

8a1ec5e

fix: delegation AccountId

8c20213

fix: renamed exists, fixed use statements

78e2b7c

wip: tests with_externalities

c380da2

fix: add sp-externalities

f574d27

fix: primitives -> sp_core

231804b

fix: add missing traits for Test

ac83051

fix: re-add BaseArithmetic to error trait

66c071a

Merge remote-tracking branch 'origin/develop' into wip-v2.0.0

4d3e5b4

chore: upgrade to rc3

367ff67

wischli reviewed Jun 9, 2020

View reviewed changes

runtime/src/ctype/tests.rs Outdated Show resolved Hide resolved

wischli and others added 3 commits June 9, 2020 12:01

fix: saturating substitution on constant

466ab19

feat: add editor config

1cbf409

feat: add nextIndex RPC

21983eb

we can now get the next tx nonce with respect to the tx pool closes KILTprotocol/ticket/issues/549

weichweich mentioned this pull request Jun 15, 2020

feat: multiple transactions per account KILTprotocol/sdk-js#220

Merged

5 tasks

weichweich added 2 commits June 19, 2020 11:21

chore: update consensus and authoring

d64a7ef

closes KILTprotocol/ticket/issues/406

fix ToC, add explanation

c00862b

wischli mentioned this pull request Jun 19, 2020

chore: upgrade dependencies KILTprotocol/sdk-js#273

Merged

5 tasks

Merge remote-tracking branch 'origin/develop' into wip-v2.0.0

8cde9cc

weichweich changed the title ~~Update to Substrate v2.0.0~~ chore: Update to Substrate v2.0.0-rc3 Jun 22, 2020

chore: upgrade wasm builder version

5a1d160

wischli approved these changes Jun 23, 2020

View reviewed changes

rflechtner reviewed Jun 24, 2020

View reviewed changes

tjwelde suggested changes Jun 25, 2020

View reviewed changes

weichweich and others added 7 commits June 25, 2020 15:45

update spec version

7b3fdb9

tabs... 🙄

d2f5e99

use as public keys

8d75804

Don't use public keys as secret seeds when building account IDs

update to rc4

b0fcd8a

chore: upgrade dockerfile

c835e3b

detailed comment

8c2350f

simpler public key building

c53112e

wischli changed the title ~~chore: Update to Substrate v2.0.0-rc3~~ chore: Update to Substrate v2.0.0-rc4 Jun 26, 2020

update testnet chain spec

0540cdb

tjwelde approved these changes Jun 26, 2020

View reviewed changes

weichweich merged commit 60fa800 into develop Jun 26, 2020

weichweich deleted the wip-v2.0.0 branch June 26, 2020 12:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update to Substrate v2.0.0-rc4 #81

chore: Update to Substrate v2.0.0-rc4 #81

weichweich commented Mar 26, 2020 •

edited by wischli

Loading

weichweich commented Jun 9, 2020

wischli left a comment

rflechtner left a comment

rflechtner Jun 24, 2020

rflechtner Jun 24, 2020

wischli Jun 25, 2020

rflechtner Jun 24, 2020

wischli Jun 25, 2020

weichweich Jun 25, 2020

wischli Jun 25, 2020

GustavHemmelmayr Jun 29, 2020

tjwelde Jun 25, 2020

weichweich Jun 25, 2020

tjwelde Jun 25, 2020

tjwelde Jun 25, 2020

wischli Jun 25, 2020 •

edited

Loading

tjwelde Jun 25, 2020

tjwelde Jun 25, 2020

tjwelde Jun 25, 2020

tjwelde commented Jun 26, 2020

chore: Update to Substrate v2.0.0-rc4 #81

chore: Update to Substrate v2.0.0-rc4 #81

Conversation

weichweich commented Mar 26, 2020 • edited by wischli Loading

Update to Substrate 2.0.0

ToDos

How to test:

Checklist:

weichweich commented Jun 9, 2020

wischli left a comment

Choose a reason for hiding this comment

rflechtner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wischli Jun 25, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tjwelde commented Jun 26, 2020

weichweich commented Mar 26, 2020 •

edited by wischli

Loading

wischli Jun 25, 2020 •

edited

Loading