feat: add new DID runtime APIs to aid with DID deletion #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntn-x2
requested review from
Ad96el and
rflechtner
and removed request for
Ad96el
Ad96el
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/KILTprotocol/ticket/issues/3742.
The PR introduces two new runtime APIs: one that returns an
enumof "linked resources", which some clients might find useful to understand why a DID deletion failed, and one that returns a list ofRuntimeCalls, that could be extended with adid.delete()call, put together into autility.batch*, and submitted to the chain, and be sure the DID deletion will work as expected (as long as all the DID origin requirements are met).