Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: define props #41

Merged
merged 3 commits into from
Oct 20, 2023
Merged

feat: define props #41

merged 3 commits into from
Oct 20, 2023

Conversation

kilted-andres
Copy link
Contributor

fixes KILTProtocol/ticket#No Ticket

Stops errors when github does it's test build.

Define Properties of components and relax es-lint a bit:

"@typescript-eslint/no-explicit-any": "warn"

Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - Fix me: TS2322: Type '{ children: string; disabled: PubSubSessionV1 | PubSubSessionV2 | null; onClick: () => Promise<void>; }' is not assignable to type 'IntrinsicAttributes & Props'.

@kilted-andres
Copy link
Contributor Author

I should have ran it before. My bad.

It's fixed now.

Copy link
Member

@Dudleyneedham Dudleyneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilted-andres kilted-andres merged commit 1196cd8 into main Oct 20, 2023
1 check passed
@kilted-andres kilted-andres deleted the xw--chill-eslint-down branch October 20, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants