Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: config ctype #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: config ctype #43

wants to merge 4 commits into from

Conversation

Dudleyneedham
Copy link
Member

fixes https://github.com/KILTprotocol/ticket/issues/2911

Creating a configurable ctype with trusted attesters and attributes.

How to test:

Please provide a brief step-by-step instruction.
If necessary provide information about dependencies (specific configuration, branches, database dumps, etc.)

  • Step 1
  • Step 2
  • etc.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

Comment on lines 29 to 34
export const CTYPE_HASH =
loadEnv('CTYPE_HASH') ||
'0x3291bb126e33b4862d421bfaa1d2f272e6cdfc4f96658988fbcffea8914bd9ac'
export const TRUSTED_ATTESTERS =
loadEnv('TRUSTED_ATTESTERS') ||
'did:kilt:4pehddkhEanexVTTzWAtrrfo2R7xPnePpuiJLC7shQU894aY'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to move the hash and did to constants and describe what they are. (which attester, which ctype)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is really no definition for the constants on .env, the loadEnv() is going to throw before the fallback option is processed.

Comment on lines 5 to 7
// Here you can set which type of credential (cType) your dApp will request users to login.
// You can change it by importing a different one from the list.
// The default is the Email CType by SocialKYC and SocialKYC as the Issuer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants