-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hash to tarballs so additional samples can be produced for an exi… #36
Conversation
This would work as long as the |
Yes, same sample types worked already before. I thought about this PR a bit more and I will implement it properly with multiple tarballs, split per era and sampletype to get a much cleaner implementation |
@nshadskiy If you could have a look again, now KingMaker keeps track of which builds are already done, and provides one tarball per sample / era. If new / other samples are requested, now only builds that are not there yet will be rebuild. I tested it for various setups and did not encounter any problems |
I think this looks fine. |
feel free to approve and merge then :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, made the comment at the wrong place. Looks fine :D
…sting production tag