Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hash to tarballs so additional samples can be produced for an exi… #36

Merged
merged 10 commits into from
May 6, 2024

Conversation

harrypuuter
Copy link
Contributor

…sting production tag

@harrypuuter harrypuuter requested a review from nshadskiy May 3, 2024 15:23
@nshadskiy
Copy link
Contributor

This would work as long as the sample_types are different from the sample_types of all the previous productions, right?

@harrypuuter
Copy link
Contributor Author

Yes, same sample types worked already before. I thought about this PR a bit more and I will implement it properly with multiple tarballs, split per era and sampletype to get a much cleaner implementation

@harrypuuter
Copy link
Contributor Author

@nshadskiy If you could have a look again, now KingMaker keeps track of which builds are already done, and provides one tarball per sample / era. If new / other samples are requested, now only builds that are not there yet will be rebuild. I tested it for various setups and did not encounter any problems

@nshadskiy
Copy link
Contributor

I think this looks fine.

@harrypuuter
Copy link
Contributor Author

feel free to approve and merge then :)

Copy link
Contributor

@nshadskiy nshadskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, made the comment at the wrong place. Looks fine :D

@nshadskiy nshadskiy merged commit d9cb5d8 into main May 6, 2024
1 of 2 checks passed
@harrypuuter harrypuuter deleted the xrootthreads branch May 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants