Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

Define direction of sampling in the Sampler-module #174

Closed
SMEISEN opened this issue Jan 14, 2022 · 1 comment · Fixed by #182
Closed

Define direction of sampling in the Sampler-module #174

SMEISEN opened this issue Jan 14, 2022 · 1 comment · Fixed by #182
Assignees
Labels
bug Something isn't working module This issue involves a specific module

Comments

@SMEISEN
Copy link
Collaborator

SMEISEN commented Jan 14, 2022

What is your feature request related to?

  • Problem related

Please describe the module/problem

Currently, the Sampler samples the data in backwarding direction:

data = [1,2,3,4,5]
Sampler(3)
===========================================
[1,0,0]; [2,1,0]; [3,2,1], [4,3,2], [5,4,3]

Describe the solution you'd like
Allow sampling in forwarding direction

data = [1,2,3,4,5]
Sampler(-3)
===========================================
[0,0,1]; [0,1,2]; [1,2,3], [2,3,4], [3,4,5]
@SMEISEN SMEISEN added enhancement New feature or request module This issue involves a specific module labels Jan 14, 2022
@SMEISEN SMEISEN self-assigned this Jan 14, 2022
@SMEISEN
Copy link
Collaborator Author

SMEISEN commented Jan 14, 2022

Maybe change the syntax of sample_size

positive for sampling in forwarding direction
negative for sampling in backwarding

Implement FutureWarning?

@SMEISEN SMEISEN added bug Something isn't working and removed enhancement New feature or request labels Feb 28, 2022
benHeid pushed a commit that referenced this issue Mar 1, 2022
* add forward sampling if sample_size < 0
* adapt test for the forward sampling
* add exception to prevent negative sample sizes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working module This issue involves a specific module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant