Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

Feature/#165 ensemble module #173

Merged
merged 12 commits into from
Mar 22, 2022
Merged

Feature/#165 ensemble module #173

merged 12 commits into from
Mar 22, 2022

Conversation

SMEISEN
Copy link
Collaborator

@SMEISEN SMEISEN commented Jan 14, 2022

Description

implements the ensemble module for post-processing
note: determining weights based on loss-values uses the RmseCalculator, which will be deprecated soon

Related Issues

closes #165

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos)
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Did you update the CHANGELOG

PR review

Anyone in the community is free to review the PR once the tests have passed.

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones to the PR so it can be classified

@SMEISEN SMEISEN added enhancement New feature or request module This issue involves a specific module labels Mar 14, 2022
@SMEISEN SMEISEN requested a review from benHeid March 14, 2022 10:54
Copy link
Collaborator

@benHeid benHeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for implementing this feature. Please consider the remarks.

pywatts/modules/postprocessing/ensemble.py Show resolved Hide resolved
pywatts/modules/postprocessing/ensemble.py Outdated Show resolved Hide resolved
pywatts/modules/postprocessing/ensemble.py Outdated Show resolved Hide resolved
@SMEISEN SMEISEN requested a review from benHeid March 17, 2022 10:36
benHeid
benHeid previously approved these changes Mar 18, 2022
benHeid
benHeid previously approved these changes Mar 18, 2022
@benHeid benHeid merged commit 69fa5c8 into master Mar 22, 2022
@benHeid benHeid deleted the feature/#165_ensemble_module branch December 1, 2022 08:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request module This issue involves a specific module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensemble module for post-processing
2 participants