-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for DL Stage #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this looks good to me, I just found a few inconsistencies regarding formatting of the code and one change that looks redundant to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one line remaining where the indendation is still wrong. Apart from this, everything looks good to me now.
Your point about the typo in the debug code is valid. I agree that it is probably better to fix this in a separate commit, because it is unrelated to adding support for the DL stage.
I think that the whole handling of debugging isn’t very nice at the moment. It would be better to use asynPrint wherever possible and use conditional debug statements everywhere else (or, if someone is really worried about performance, wrap the debug code in #ifdef
s). Just about every other solution is clearner than leaving commented out code in the sources. However, this is a completely separate issue, so I do not think that this has to or should be addressed in the context of this PR.
Source is the internal patch file
I removed the
std::cout
commands and also therefore#include <iostream>
This is IBPT internal review, after that I would create a PR to upstream