[Feature/#17] onboarding sensor #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marchbreeze
approved these changes
Jul 30, 2024
|
|
||
| class OnboardingMeasureFragment : | ||
| BaseFragment<FragmentOnboardingMeasureBinding>(R.layout.fragment_onboarding_measure), | ||
| SensorEventListener { |
There was a problem hiding this comment.
리스너를 프래그먼트 선언부에 넣어주는 이유는 무엇인가요?
There was a problem hiding this comment.
리스너를 상속시켜서 onSensorChanged와 같은 함수를 override하기 위함입니다~
Comment on lines
+33
to
+34
| sensorManager = requireContext().getSystemService(Context.SENSOR_SERVICE) as SensorManager | ||
| stepDetectorSensor = sensorManager.getDefaultSensor(Sensor.TYPE_STEP_DETECTOR) |
There was a problem hiding this comment.
요 친구들도 함수화 따로 해주는건 어떠려나요 init으로?
그리고 as 사용 괜찮나요 이 과정? (진짜 모름)
There was a problem hiding this comment.
함수화 했습니다~ 자주 까먹네용
그리고 여기서 as사용하는건 괜차나요~~ Sensor Service를 반환하여 Manager로 바꿔주고 있기도 하고, Sensor관련으로 사용해주고 있어용
Comment on lines
59
to
62
| private fun initializeSensor() { | ||
| sensorManager = requireContext().getSystemService(Context.SENSOR_SERVICE) as SensorManager | ||
| stepDetectorSensor = sensorManager.getDefaultSensor(Sensor.TYPE_STEP_DETECTOR) | ||
| } |
Comment on lines
70
to
76
| if (requestCode == 200) { | ||
| if (grantResults.isNotEmpty() && grantResults[0] == PackageManager.PERMISSION_GRANTED) { | ||
| initializeSensor() | ||
| } else { | ||
| // 사용자가 권한을 거부한 경우 처리 | ||
| // 예: 사용자에게 권한의 필요성을 설명하는 다이얼로그 표시 | ||
| } |
There was a problem hiding this comment.
200 const val로 상수화해주는게 좋음~ (사실 귀찮아서 안한거 알고있음 ㅋㅋ 코리용 ~)
Comment on lines
+80
to
+90
| override fun onResume() { | ||
| super.onResume() | ||
| stepDetectorSensor?.let { | ||
| sensorManager.registerListener(this, it, SensorManager.SENSOR_DELAY_NORMAL) | ||
| } | ||
| } | ||
|
|
||
| override fun onPause() { | ||
| super.onPause() | ||
| sensorManager.unregisterListener(this) | ||
| } |
There was a problem hiding this comment.
오 이렇게 되면 이 화면이 켜져있을 때에만 스텝이 세어지는 건가요? 1분동안 측정용이라서 그런가보네용
There was a problem hiding this comment.
넵넵 맞습니다! 우선은 1분만 하는거기도 해서 화면이 켜져있어야만 가능하도록 했어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers