Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (D)Point.move(d) #1923

Closed
sebastian-goeldi opened this issue Nov 12, 2024 · 1 comment · Fixed by #1928
Closed

Add (D)Point.move(d) #1923

sebastian-goeldi opened this issue Nov 12, 2024 · 1 comment · Fixed by #1928
Assignees
@klayoutmatthias
Labels
enhancement
Milestone
0.29.9

Comments

@sebastian-goeldi
Copy link
Contributor

Hi Matthias,

I noticed basically all shape-like objects except the point ones have a move(d) function. Would it be possible to add this for Point as well?

Also, one additional question, but maybe that's not possible due to footprint matching. Would it be possible to add 0 as a default value for dx/dy? Rational being then (in python at least), you can do point.move(dy=500) without needing to specify dx and the other way around. This would be purely convenience, so if not easily achievable, that's totally okay!
klayoutmatthias pushed a commit that referenced this issue Nov 17, 2024
Implemented solution for #1923 ('move', 'moved')
476ec3a 
1. Added move and moved to Point and DPoint
2. dx/dy is 0 by default now
3. arguments of move and moved are called
   v (vector) and dx/dy consistently
@klayoutmatthias klayoutmatthias self-assigned this Nov 17, 2024
@klayoutmatthias klayoutmatthias added this to the 0.29.9 milestone Nov 17, 2024
@klayoutmatthias klayoutmatthias linked a pull request Nov 17, 2024 that will close this issue
Feature/issue 1923 #1928
Merged
@klayoutmatthias
Copy link
Collaborator

I also harmonized the parameter names ("dx", "dy") and added the default "0" for dx/dy to other objects such as edges, polygons, regions etc.

I hope this does not break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
enhancement
Projects
None yet
Milestone
0.29.9
Development

Successfully merging a pull request may close this issue.

Feature/issue 1923 KLayout/klayout
2 participants
@klayoutmatthias @sebastian-goeldi