Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup debug #1048

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Cleanup debug #1048

merged 3 commits into from
Nov 19, 2024

Conversation

xs5871
Copy link
Collaborator

@xs5871 xs5871 commented Nov 19, 2024

  • Use the debug utility everywhere.
  • Guard all debug statements.
  • Remove the legacy keyboard.debug_enabled flag / property,
  • and document debug utility usage instead

regicidalplutophage
regicidalplutophage requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the KC.DEBUG in keys.py?

@xs5871
Copy link
Collaborator Author

xs5871 commented Nov 19, 2024

I'm not sure what you're asking.

regicidalplutophage
regicidalplutophage approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@regicidalplutophage regicidalplutophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it myself 👍

@xs5871
Copy link
Collaborator Author

xs5871 commented Nov 19, 2024

I see. Actually, I wanted to keep that key. It's occasionally usefull to me.

@regicidalplutophage regicidalplutophage merged commit 8fa5259 into main Nov 19, 2024
2 checks passed
@regicidalplutophage regicidalplutophage deleted the cleanup-debug branch November 19, 2024 22:39
@regicidalplutophage
Copy link
Member

Oops.
It was of limited use now that debug handler is gone. Maybe it should be reimplemented with a different functionality that makes sense?

@xs5871
Copy link
Collaborator Author

xs5871 commented Nov 19, 2024

The debug handler isn't gone, the debug key had the same functionality just without the detour over keyboard.debug_enabled.

regicidalplutophage added a commit that referenced this pull request Nov 19, 2024
@regicidalplutophage
Revert "Cleanup debug (#1048)"
4411d16 
This reverts commit 8fa5259.
@regicidalplutophage
Copy link
Member

I see now. I've gotten illiterate as of late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regicidalplutophage regicidalplutophage regicidalplutophage approved these changes

@claycooper claycooper Awaiting requested review from claycooper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xs5871 @regicidalplutophage