Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup legacy keyboard.tap_time #1050

Merged
merged 1 commit into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions boards/atreus62/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
macros = Macros()
keyboard.modules = [layers, encoder, macros]

keyboard.tap_time = 250


# custom keys
NEW = KC.LCTL(KC.N)
Expand Down
1 change: 0 additions & 1 deletion boards/fingerpunch/ffkb/other_pro_micro/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from kmk.modules.mouse_keys import MouseKeys

keyboard = KMKKeyboard()
keyboard.tap_time = 150

# Cleaner key names
_______ = KC.TRNS
Expand Down
2 changes: 0 additions & 2 deletions boards/keebio/iris/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

keyboard = KMKKeyboard()

keyboard.tap_time = 750

_______ = KC.TRNS
xxxxxxx = KC.NO

Expand Down
1 change: 0 additions & 1 deletion boards/lunakey_pico/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
led.value = True

keyboard = KMKKeyboard()
keyboard.tap_time = 100

layers = Layers()
holdtap = HoldTap()
Expand Down
6 changes: 0 additions & 6 deletions docs/en/config_and_keymap.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,3 @@ keyboard.keymap = [[KC.A, KC.B]]
The row x column matrix structure doesn't appear explicitly
in the keymap. Use `KC.NO` to mark grid positions without a physical key.
For very sparse grids `keyboard.coord_mapping` can be useful to avoid `KC.NO`.

You can further define a bunch of other stuff:

- `keyboard.tap_time` which defines how long `KC.TT` and `KC.LT` will wait before
considering a key "held" (see `layers.md`).

2 changes: 0 additions & 2 deletions docs/en/encoder.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,6 @@ keyboard.diode_orientation = DiodeOrientation.COLUMNS
# encoder_handler.divisor = 2 # for encoders with more precision
encoder_handler.pins = ((board.GP17, board.GP15, board.GP14, False),)

keyboard.tap_time = 250


# Filler keys
_______ = KC.TRNS
Expand Down