Fix key pressed before combo making combo wait for timeout #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xs5871
reviewed
Jul 24, 2022
Comment on lines
+230
to
+231
| if not self._matching: | ||
| self.reset(keyboard) |
There was a problem hiding this comment.
This obviously only resets if no combos are matching, and doesn't reset non-matching combos if there're potential matches left. I'm not 100% sure that's perfect, but it's at least a step foward.
xs5871
reviewed
Jul 24, 2022
xs5871
approved these changes
Jul 24, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #528.
Resets combos on key-up if there isn't a current match.
Added 4 new tests for this case, too, with different delays in key press/release and checking that it works whether the other key is a combo key or "inert".
I also added some type hints to help me with debugging and left them in, hope that's alright since it'll need to be done anyway for #205.