draft concept for ble-split to transport refactor #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdb424
added
bluetooth/wireless
requires hardware testing
extension
Draft
|
Continuing work on #618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #562 here's a draft of how to seperate the BLE communication logic out into a "black box" transport.
The idea is to have "transports" that handle the wire-level communication (UART, PIO UART, BLE, I2C, ...), which only handle the transfer of a sequence of bytes; the higher level split protocol is then independent of the low level transfer protocol.
I'm currently not in a position to test and debug this suggestion and leave the PR editable to maintainers.