Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce cache expiry time to 3 days #122

Merged
merged 2 commits into from
Jan 29, 2024
Merged

reduce cache expiry time to 3 days #122

merged 2 commits into from
Jan 29, 2024

Conversation

nikkaroraa
Copy link
Collaborator

@nikkaroraa nikkaroraa commented Jan 29, 2024

Task:

Reduce cache expiry time from 30 days to 3 days

Description

Originally, the setting was for 30 days, indicating that when a data center is whitelisted, existing users would only gain access to the site after 30 days from their initial visit. However, a 3-day period seems to be an optimal balance, reducing the frequency of API calls while also avoiding issues with outdated data.

Fixes ENG-2043

Type of change

  • New feature
  • Bug fix
  • Testing code
  • Document update or config files

Copy link

linear bot commented Jan 29, 2024

Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
squeeth-portal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:19pm
squeeth-portal-goerli ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:19pm
squeeth-portal-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 2:19pm

Copy link
Collaborator

@alpinechicken alpinechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikkaroraa nikkaroraa merged commit adcd693 into main Jan 29, 2024
5 checks passed
@nikkaroraa nikkaroraa deleted the reduce-expiry-time branch January 29, 2024 18:14
Copy link

linear bot commented Jan 31, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants